Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR implements an "Or" combinator for the traversable visitor pattern, allowing developers to compose multiple visitors that execute sequentially on each node during traversal.
Key changes:
- Added a new
combinatormodule withVisitorExtandVisitorMutExttraits providing theor()method - Implemented
OrVisitorstruct that combines two visitors with short-circuit behavior onBreak - Added comprehensive test coverage including normal execution and break scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
traversable/src/combinator.rs |
New module implementing visitor combinator traits and the OrVisitor type with proper short-circuit semantics |
traversable/src/lib.rs |
Added public export of the new combinator module |
traversable/tests/test_combinator.rs |
Comprehensive test suite covering sequential visitor execution, break behavior for both visitors, and mutable visitor composition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
@andylokandy may be more proper to name it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @andylokandy